Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes] Fix typo in readmes and parameter files: "privateDnsZoneGroups" to "privateDnsZoneGroup" #2137

Merged
merged 3 commits into from
Sep 28, 2022
Merged

[Fixes] Fix typo in readmes and parameter files: "privateDnsZoneGroups" to "privateDnsZoneGroup" #2137

merged 3 commits into from
Sep 28, 2022

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Sep 28, 2022

Description

The parameter "privateDnsZoneGroup" is falsely used in some files as "privateDnsZoneGroups".

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@rahalan rahalan requested a review from a team as a code owner September 28, 2022 07:53
@rahalan
Copy link
Contributor Author

rahalan commented Sep 28, 2022

See #2122

@eriqua eriqua changed the title Fix typo in readmes and parameter files: "privateDnsZoneGroups" to "privateDnsZoneGroup" [Modules] Fix typo in readmes and parameter files: "privateDnsZoneGroups" to "privateDnsZoneGroup" Sep 28, 2022
@eriqua eriqua changed the title [Modules] Fix typo in readmes and parameter files: "privateDnsZoneGroups" to "privateDnsZoneGroup" [Fixes] Fix typo in readmes and parameter files: "privateDnsZoneGroups" to "privateDnsZoneGroup" Sep 28, 2022
eriqua
eriqua approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua mentioned this pull request Sep 28, 2022
Closed
@rahalan rahalan merged commit 6ef4a43 into main Sep 28, 2022
@rahalan rahalan deleted the users/rahalan/FixParam branch September 28, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@rahalan rahalan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahalan @eriqua